search

clarity-h2020 / map-component

The Map Component is a reusable, flexible and highly configurable Building Block meant to be used throughout CSIS.
https://csis.myclimateservice.eu/
1 stars 1 forks source link

CSIS study - coastal cities area selection #71

Closed mattia-leone closed 5 years ago

mattia-leone commented 5 years ago

Selecting a box with a portion in the sea creates this issue

Schermata 2019-11-26 alle 10 52 13

The portion of sea should be included in the city borders to perform the study

DenoBeno commented 5 years ago

An alternative would be to allow users to choose an area as long as part of it is within a city area. Not sure if the calculations woudl perform properly in this case -- @humerh , WDYT?

p-a-s-c-a-l commented 5 years ago

@therter Is that error message coming from the map component? Why is it even possible, to select a study area outside of the city polygon?

humerh commented 5 years ago

From my side I see no problem.

therter commented 5 years ago

I can import the envelope of the city polygon instead of the detailed polygon. This should solve the problem. Should I do this?

p-a-s-c-a-l commented 5 years ago

This should solve the problem.

I don't think so. What happens if somebody selects a study area in the gulf of Naples? What would the model calculate then? Nothing useful I suppose.

As Denis suggested we should check whether the study area intersects with the city polygon. ATM you are checking for "contains", right?

therter commented 5 years ago

As Denis suggested we should check whether the study area intersects with the city polygon. ATM you are checking for "contains", right?

That is right, but I can change this.

DenoBeno commented 5 years ago

So this is done?

therter commented 5 years ago

Yes, this is done