Report Generation - Githubissues

clarity-h2020 / scenario-analysis

Customised versions of the CRISMA Scenario Comparison and Analysis and the Multi-Criteria-Analysis and Decision Support Functional Building Blocks for integration within the CLARITY CSIS.

https://clarity-h2020.github.io/scenario-analysis/index.html

GNU Lesser General Public License v3.0

4 stars 0 forks source link

Report Generation #3

Closed p-a-s-c-a-l closed 4 years ago

p-a-s-c-a-l commented 5 years ago

Add support for Report Generation. ~~based on angular-screenshot to create a screenshot of the respective diagram DOM Element and send image data to the Drupal REST API.~~

p-a-s-c-a-l commented 5 years ago

Drop support for angular-screenshot as it supports only Chrome. See https://github.com/weihanchen/angular-screenshot/issues/2

p-a-s-c-a-l commented 5 years ago

We use html2canvas to generate a screenshot of the map area that should be included in the report and upload the PNG image to Drupal. However, at the moment Files created with REST API are only temporary!

p-a-s-c-a-l commented 5 years ago

For CSIS v1, the report Viewer could be implemented using pdf.js to show server-side generated report.

p-a-s-c-a-l commented 5 years ago

JSON:API shall be used for saving screenshots: Allow creation of file entities from binary data

ci-cismet-de commented 5 years ago

Integrated branch 'feature/03-report-generation (68f4cae7514967a12f42c89f47ea008206eac944)' into 'dev (f1b79f57a4dc8376171627cddb82a8f1cb6da6ed)' -- Build 27

p-a-s-c-a-l commented 5 years ago

done

p-a-s-c-a-l commented 5 years ago

Don't trust URIs in JSON received from Drupal JSON:API: https://github.com/clarity-h2020/docker-drupal/issues/57

p-a-s-c-a-l commented 5 years ago

Instead of sending a GET request for the GL-Step and later PATCHing that same GL-Step with the new Report Image, I'm sending another POST request in the end against the relationship endpoint for the Report Images array of the GL-Step: https://github.com/clarity-h2020/docker-drupal/issues/46#issuecomment-482537744
Store the relationship between GL-Step and Report image only in the Report image. The field report_images in the GL-Step should not be used anymore and can at some point be removed: https://github.com/clarity-h2020/docker-drupal/issues/81#issuecomment-509620625

p-a-s-c-a-l commented 4 years ago

Might become resolved in https://github.com/clarity-h2020/csis-helpers-module/issues/13

DenoBeno commented 4 years ago

We have a report generation now. Can this be closed?

p-a-s-c-a-l commented 4 years ago

No, it's still not working with the Scenario Analysis App. See https://github.com/clarity-h2020/csis-helpers-module/issues/9#issuecomment-539633877

p-a-s-c-a-l commented 4 years ago

Is being addressed here.