clarity-h2020 / table-components

Table Components Building Block
GNU Lesser General Public License v3.0
1 stars 0 forks source link

Please expose the link for downloading the table data from EMIKAT #21

Closed DenoBeno closed 5 years ago

DenoBeno commented 5 years ago

As discussed yesterday, @mattia-leone needs a simple way to download the table data in our studies.

@patrickkaleta and I looked at this today and this would be difficult to do from the drupal side. We do know the variable values but we do not know which data is shown where, so this would need to be hard-coded in drupal - not a good idea.

Therefore, I propose to do this in the CIS table component. Since the link will not work for normal users, ideally it should be hidden from them, based on their user role. E.g., the link could be shown to users with "editor" role. If a role is not already listed, then the helper module might need to be changed.

DenoBeno commented 5 years ago

@p-a-s-c-a-l : this is pretty much irrelevant feature for CSIS, but we badly need to get the results validated. And for this, the results must be easily accessible for climate experts, not just for the technical users that can open a console and see what was called.

p-a-s-c-a-l commented 5 years ago

Since the link will not work for normal users, ideally it should be hidden from them, based on their user role

Hiding the link / button would be difficult to do from the external application side so it will not be supported in the short term. But why is that needed anyway? What is a 'normal' user? Why shouldn't such a user be allowed to download the data?

But adding a simple download button which calls EMIKAT CSV API should not be a big issue.

DenoBeno commented 5 years ago

My main issue is that "normal user" doesn't have EMIKAT login. But other than that, I don't really care. What I do care about is that @mattia-leone has a quick access to the data.

p-a-s-c-a-l commented 5 years ago

Any user needs an "EMIKAT login" (Basic Authentication) to view data in a table. This is already part of the user profile.

p-a-s-c-a-l commented 5 years ago

File Download is now implemented: https://csis.myclimateservice.eu/study/33/step/1517/view/table

CSV download currently does not work till @humerh fixes this issue.

DenoBeno commented 5 years ago

great!

On Fri, 25 Oct 2019, 15:16 Pascal Dihé, notifications@github.com wrote:

File Download is now implemented: https://csis.myclimateservice.eu/study/33/step/1517/view/table

CSV download currently does not work till @humerh https://github.com/humerh fixes this issue https://github.com/clarity-h2020/emikat/issues/1#issuecomment-545952761.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clarity-h2020/table-components/issues/21?email_source=notifications&email_token=AAWTC7X5IGXIV5CCV4FMFJDQQLWRLA5CNFSM4JD6VDT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIKCMI#issuecomment-546349361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWTC7X2TK2752CAEXBJV6DQQLWRLANCNFSM4JD6VDTQ .

p-a-s-c-a-l commented 5 years ago

done here