search

clarity20 / tql

Terse Query Language
1 stars 0 forks source link

Improve the handling of NULLs, and related issues #31

Open clarity20 opened 5 years ago

clarity20 commented 5 years ago

Inspired by Issue # 19. While we're on the subject of handling NULLs in the SQL, this is a good time to address the issues in function useIntuitiveNulls() and related issues. This includes the extra pair of parentheses in queries NOT affected by the aforesaid function; the poor spacing of parentheses in the final WHERE clause; and the brittle treatment of case (3) near the top of that function. One more issue in that function is not yet addressable but should be soon: our identification of the full set of column names enumerated inside compound NOT clauses with default{Alnum,Num}Cols. Once we overhaul the column-name guessing in processUnnamedNCVArgument() we can & should use the effective list of columns (those which are left standing after the others are ruled out), which need not be the same as either of the present lists of defaults.

clarity20 commented 5 years ago

Commit # c29389cb clears some of the superfluous parentheses and addresses their spacing. Commit # 22a8ebc clears the others. Commit # e36c2be cleans up the brittleness of function useIntuitiveNulls().

This leaves only the column-name improvement before this issue can be retired.