[pre-commit.ci] pre-commit-autoupdate

pre-commit-ci[bot] commented 1 year ago

updates:

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc68482) 92.95% compared to head (a16e293) 92.95%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #338 +/- ## ======================================= Coverage 92.95% 92.95% ======================================= Files 40 40 Lines 3778 3778 ======================================= Hits 3512 3512 Misses 266 266 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonbarker68 commented 1 year ago

Why have these tests failed? This was just an update to various pre-commit hooks.

groadabike commented 1 year ago

Why have these tests failed? This was just an update to various pre-commit hooks.

I checked the error for my PR and is because this message

notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721 do not compare types, for exact checks use > is / is not, for instance checks use isinstance()

Do i changed a type(cfg) == Docstring to isinstance(cfg, Docstring) fixing the error

jonbarker68 commented 1 year ago

Thanks. That makes sense. So basically the flake8 update has introduced some new checks. I’ll fix this and do the merge.

On Wed, 13 Sep 2023 at 19:46, Gerardo Roa Dabike @.***> wrote:

Why have these tests failed? This was just an update to various pre-commit hooks.

I checked the error for my PR and is because this message

notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721 do not compare types, for exact checks use > is / is not, for instance checks use isinstance()

Do i changed a type(cfg) == Docstring to isinstance(cfg, Docstring) fixing the error

— Reply to this email directly, view it on GitHub https://github.com/claritychallenge/clarity/pull/338#issuecomment-1718143524, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E . You are receiving this because you commented.Message ID: @.***>

groadabike commented 1 year ago

Thanks. That makes sense. So basically the flake8 update has introduced some new checks. I’ll fix this and do the merge. …

I did the fix and pushed it. Now the pre-commit check passed

jonbarker68 commented 1 year ago

Thanks for that.

On Thu, 14 Sept 2023 at 20:03, Gerardo Roa Dabike @.***> wrote:

Thanks. That makes sense. So basically the flake8 update has introduced some new checks. I’ll fix this and do the merge. … <#m250533183976321632> On Wed, 13 Sep 2023 at 19:46, Gerardo Roa Dabike @.> wrote: Why have these tests failed? This was just an update to various pre-commit hooks. I checked the error for my PR and is because this message notebooks/03_Running_the_CEC2_baseline_from_python.ipynb:cell_4:4:8: E721 do not compare types, for exact checks use > is / is not, for instance checks use isinstance() Do i changed a type(cfg) == Docstring to isinstance(cfg, Docstring) fixing the error — Reply to this email directly, view it on GitHub <#338 (comment) https://github.com/claritychallenge/clarity/pull/338#issuecomment-1718143524>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E https://github.com/notifications/unsubscribe-auth/ACO7SJA6CBPSL3W2NHQXVBLX2H5RNANCNFSM6AAAAAA27TPL7E . You are receiving this because you commented.Message ID: @.>

I did the fix and pushed it. Now the pre-commit check passed

— Reply to this email directly, view it on GitHub https://github.com/claritychallenge/clarity/pull/338#issuecomment-1719988220, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACO7SJFGMAXMN63JU6ACF5TX2NIHPANCNFSM6AAAAAA27TPL7E . You are receiving this because you commented.Message ID: @.***>

-- Professor Jon Barker, Department of Computer Science, University of Sheffield +44 (0) 114 222 1824

groadabike commented 1 year ago

keeping the numpy version lower than 1.25.0 "fixed" the issue. but, we still need to find what is the main problem

claritychallenge / clarity

[pre-commit.ci] pre-commit-autoupdate #338

Codecov Report