claritychallenge / clarity

Clarity Challenge toolkit - software for building Clarity Challenge systems
https://claritychallenge.github.io/clarity
MIT License
129 stars 54 forks source link

Fixed smear3 to work with newer numpy versions #346

Closed jonbarker68 closed 1 year ago

jonbarker68 commented 1 year ago

This should fix the problem that was causing some tests to fail with the newer numpy versions.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (e4656ec) 92.86% compared to head (752d230) 92.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== - Coverage 92.86% 92.86% -0.01% ========================================== Files 43 43 Lines 3924 3923 -1 ========================================== - Hits 3644 3643 -1 Misses 280 280 ``` | [Files Changed](https://app.codecov.io/gh/claritychallenge/clarity/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [clarity/evaluator/msbg/smearing.py](https://app.codecov.io/gh/claritychallenge/clarity/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y2xhcml0eS9ldmFsdWF0b3IvbXNiZy9zbWVhcmluZy5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonbarker68 commented 1 year ago

@groadabike this fixes the numpy 1.25 and 1.26 issues

groadabike commented 1 year ago

That's great, thank you for this.

On Sun, 17 Sept 2023, 18:58 Jon Barker, @.***> wrote:

@groadabike https://github.com/groadabike this fixes the numpy 1.25 and 1.26 issues

— Reply to this email directly, view it on GitHub https://github.com/claritychallenge/clarity/pull/346#issuecomment-1722531034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AED2G2SUARD46Z7QZWJR6NLX2423NANCNFSM6AAAAAA43YDEUE . You are receiving this because you were mentioned.Message ID: @.***>