claritylab / lucida

Speech and Vision Based Intelligent Personal Assistant
Other
4.81k stars 879 forks source link

Update start servers #163

Closed saijel closed 7 years ago

saijel commented 7 years ago

list of changes:

jhauswald commented 7 years ago

I still need to test all this out but there are some discussion points as well

jhauswald commented 7 years ago

After testing:

saijel commented 7 years ago

Answers below.


Saijel Mokashi https://clinc.com

On Mon, Apr 17, 2017 at 8:29 AM, Johann Hauswald notifications@github.com wrote:

After testing:

  • what's the first vim window for? I added this window to do development in. I guess it is not completely necessary. Should I remove it?
  • can you add a check if I already have a window named lucida? Yes, I added this check and updated the pull request.
  • can you add a check to not nest tmux sessions if i'm already in tmux? This is generally bad practice. Fixed in the above statement
  • how do i got about adding a new service? is that automatic or do I need to edit the bash script everytime? Is this related to your registry idea? Currently, you'd have to edit the bash script every time. I think the entire process of adding a microservice needs to be planned out to try to make it more automated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/claritylab/lucida/pull/163#issuecomment-294475331, or mute the thread https://github.com/notifications/unsubscribe-auth/AZQku_nKUCzHuCW5sYZF0_cuWpvT4R4fks5rw1s2gaJpZM4MztZ6 .

jhauswald commented 7 years ago

Went through all your responses, yes I would remove the development window from tmux. Agreed on everything else.

jhauswald commented 7 years ago

Also what about the fixes that you have? can you make a quick MR for those?