search

claritylab / lucida

Speech and Vision Based Intelligent Personal Assistant
Other
4.81k stars 883 forks source link

Singleton #251

Open JaydonFernandes opened 3 years ago

seraasch commented 3 years ago

Jayson - This project is essentially abandoned. You might consider cloning it.

jhauswald commented 3 years ago

Hey @JaydonFernandes thank you for both of your PRs! While @seraasch mentioned this project has been silent for some time, we'd definitely welcome contributions and continued support from the community.

Could you add a more detailed description so we can better understand the goal of the PR and how to test? I'll have to get reacquainted with this code, especially OpenEphyra was a project developed by researchers at CMU a while back.

JaydonFernandes commented 3 years ago

Hey @jhauswald this is actually for one of our university classes. Our goal was to find a project on GitHub and see where we can implement a design pattern. We chose the SentenceExtractor class as there is only a need for a single instance of it in the system and having multiple instances could make the data inconsistent. We saw that many of its fields and methods were static to prevent to against this. However, by making it a singleton we can now ensure that there is only at most one instance for the whole system.

All tests should pass with this new change as it does not change any of the logic or functionality, only makes it more robust.