clariusdev / mobileapi

Android API Allowing IPC with the Clarius App
https://www.clarius.com
BSD 3-Clause "New" or "Revised" License
12 stars 4 forks source link

Feature Request: Settings API `BUTTON_USER` set individual sub-settings #24

Closed nnaskov closed 2 years ago

nnaskov commented 2 years ago

Hi,

Thanks for fixing #18 . I can verify that the API now works as expected.

However, this still doesn't solve our use-case. After setting the buttons to be BUTTON_USER, there are default Single Click actions, namely - Freeze and Capture Image. Screenshot_20220613-105313

We want to have a custom Button Action in our app, so if a Single Click is "Freeze", we constantly get unexpected frozen stream, when we use the buttons in our app. We need all Clarius functionality to be "Disabled", to make it work. This is the desired final setup:

Screenshot_20220613-105817

Could you implement an API, which will allow me to Disable all sub-options for a button? For example:

....
  settings.buttonUp = SettingsInfo.BUTTON_USER
  settings.buttonUpSingleClick = SettingsInfo.DISABLED
  settings.buttonUpDoubleClick = SettingsInfo.DISABLED
  settings.buttonUpTripleClick = SettingsInfo.DISABLED
  settings.buttonUpQuadClick = SettingsInfo.DISABLED

  settings.buttonDown = SettingsInfo.BUTTON_USER
  settings.buttonDownSingleClick = SettingsInfo.DISABLED
  settings.buttonDownDoubleClick = SettingsInfo.DISABLED
  settings.buttonDownTripleClick = SettingsInfo.DISABLED
  settings.buttonDownQuadClick = SettingsInfo.DISABLED
...
julien-l commented 2 years ago

Hello thank you for the feedback, I took note of your request and we will discuss it at our next engineering meeting. Julien

julien-l commented 2 years ago

Hello we have reviewed your request during engineering meeting and decided not to implement it. Reason: we think that Mobile API is appropriate for simple use cases where 3rd party apps only need to receive images from the Clarius App. For more complicated workflows requiring specific app settings, we think the OEM solution is more appropriate.