search

clariuslabs / TransformOnBuild

Transform Text Templates On Build
Apache License 2.0
48 stars 17 forks source link

Include vs2019 paths for TextTransform #62

Closed ernestns closed 3 years ago

stephenpatten commented 5 years ago

This would be helpful for those of us who are using corporate window images that ONLY contain VS 2019 now.

Thank you, Stephen

barjonas commented 5 years ago

Why not use the DevEnvDir environment variable at the top of the path list? That would make it forwards and backwards compatible in many cases. I'm currently working around this issue with this in my .csproj.

  <PropertyGroup>
    <TextTransformPath>$(DevEnvDir)TextTransform.exe</TextTransformPath>
  </PropertyGroup>
StormPooper commented 4 years ago

The .csproj method works for VS directly, but when I try and call MSBuild on a specific project file, it still can't find it, so having this PR merged in would still be useful.

Update: Turned out DevEnvDir isn't set on some build servers or installs, managed to get it working by doing this instead:

<PropertyGroup>
  <TextTransformPath>$(VsInstallRoot)\Common7\IDE\TextTransform.exe</TextTransformPath>
</PropertyGroup>
jimmyheaddon commented 4 years ago

Any update on this being merged in? :)

jimmyheaddon commented 4 years ago

For consistency sake, should the VS 2019 paths be at the top, given that the other paths appear to be in reverse chronological order, looking at the tooling version numbers?

rperezretana commented 4 years ago

Is this going to be approved/merged? I been waiting for the fix for a while, and I am about to stop using this project just for this bug.

Maximetinu commented 3 years ago

Same problem here

kzu commented 3 years ago

Sorry it took so long, I'm back :)