search

clarkbw / about-history

A firefox add-on with an awesome history view
Other
13 stars 7 forks source link

Use release version of backbone #111

Closed erikvold closed 10 years ago

erikvold commented 10 years ago

We were rejected because of this:

"We can't match your included version of backbone-min.js to the checksum of any known version. Please include only releases of libraries obtained from official sources in their original, unmodified files. Please note that third party CDNs are not considered official sources for this purpose."

erikvold commented 10 years ago

Actually I think we should just remove jQuery, underscore, and Backbone and save ourselves future pain asap.

clarkbw commented 10 years ago

We can definitely double check the backbone releases but moving away from the frameworks I'd worry that it will make it harder for other people to contribute.

I'd be more inclined to use the bwinton system of hosting our own addons so we can rev the versions faster and not deal with these annoying review cycles.

clarkbw commented 10 years ago

Weird, I just double checked the backbone we're using, it's production 1.1.2 from http://backbonejs.org/

shasum chrome/content/js/backbone-min.js
42ef07a70aa727cd721aec4112ed0bcc94801faa  chrome/content/js/backbone-min.js
curl -O http://backbonejs.org/backbone-min.js
shasum backbone-min.js
42ef07a70aa727cd721aec4112ed0bcc94801faa  backbone-min.js

I can't check in the downloaded version because git says there's no difference.

erikvold commented 10 years ago

@kmaglione any idea what the issue is?

clarkbw commented 10 years ago

Can't figure out a way to fix this, our included backbone is the release version. I just double checked again. :panda_face: