clarkbw / jest-webextension-mock

A module to mock WebExtensions in Jest
BSD 3-Clause "New" or "Revised" License
93 stars 37 forks source link

Add contribution guidelines #130

Open pinn3 opened 3 years ago

pinn3 commented 3 years ago

While making the changes for #129 I felt that there may be a need for this.

By the looks of the commit log, the format of the messages varies quite a lot. I'm also wondering about what the preferred merge strategy is, like would it be appreciated if one was to keep their branch up to date with master through rebasing? I'm not sure if this is something that is valued here, it might just be me that is overly picky about such things.

Other than that, clarifying the goal with this mocking library might be beneficial. I mentioned in #129 that the changes only seem to relevant for Chrome extensions. Should such cases be supported by this project, or should anything outside of the actual WebExtensions API be omitted?

RickyMarou commented 4 months ago

FYI the repo has moved over to https://github.com/RickyMarou/jest-webextension-mock/

That's a great suggestion that is on my radar, i already made the move to use changesets so it'll be easier to write changelogs for this project.

Essentially what I want to do is: