search

clarkbw / jest-webextension-mock

A module to mock WebExtensions in Jest
BSD 3-Clause "New" or "Revised" License
93 stars 37 forks source link

Chore/update build #162

Closed escapedcat closed 2 years ago

escapedcat commented 2 years ago

Noticed that even after updating to v3.8.0 jest still failed. I guess because it's using the build which makes sense.
Noticed that the build hasn't been updated for a longer time.
This should fix it 🤞
Would need another release I guess.

You want to add 3.8.0 to the releases as well?

codecov[bot] commented 2 years ago

Codecov Report

Base: 99.50% // Head: 99.50% // No change to project coverage :thumbsup:

Coverage data is based on head (a41935f) compared to base (f3d1f6d). Patch has no changes to coverable lines.

:exclamation: Current head a41935f differs from pull request most recent head b940a99. Consider uploading reports for the commit b940a99 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #162 +/- ## ======================================= Coverage 99.50% 99.50% ======================================= Files 14 14 Lines 202 202 Branches 43 43 ======================================= Hits 201 201 Misses 1 1 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

clarkbw commented 2 years ago

Thanks for this! I'll probably need a patch release to actually roll out the changes.

That was supposed to be checked by the push action such that it doesn't allow merging if the build doesn't match the a rebuild...

escapedcat commented 2 years ago

Thanks for this! I'll probably need a patch release to actually roll out the changes.

❤️ Yeah, I guess so as well. That's fine though.