search

clarkbw / searchspot

Firefox add-on for better searching. Multiple search suggestions from a number of different providers. Local search based on GeoLocation. Better search engine preferences management.
13 stars 5 forks source link

focus remains in the search entry #9

Closed clarkbw closed 12 years ago

clarkbw commented 12 years ago

After you complete a search the focus somehow remains in the search entry and we need to transfer it to the document or something so the search results don't popup unintended.

clarkbw commented 12 years ago

Additional details from the review.

You may want to look into edge-cases related to changing the focus away from the search box while asynchronous queries were in flight or using hot-keys. For example, on linux, pressing control-T caused focus to switch to the address bar, but the awesome search panel remained visible (or became visible again). An additional detail is that when I would press the control key down, the panel would go away, but when I released the control key, the panel would come back. So I suspect that the control-T sequence may involve some type of race that may be related to that. Because it is easy to make the panel go away by clicking into the box and clicking away again, I don't think this behaviour merits holding back approving the add-on. (In fact, I only noticed problems when I started getting fancy with hot-keys and performing usage patterns that I don't think would be too common when using the dedicated search box.)

clarkbw commented 12 years ago

This is fixed but there is another issue that needs to be addressed, opened issue #17 to further look into the panel remaining open.