search

clarkduvall / JSOL

JSON programming language
Apache License 2.0
74 stars 5 forks source link

Remove the JSON / PSOL radio buttons #3

Closed LarryBattle closed 12 years ago

LarryBattle commented 12 years ago

On the homepage, I think you should remove the JSOL and PSOL radio buttons since they don't update the view automatically and also they don't work.

Cool project by the way.

clarkduvall commented 12 years ago

Hmm, I agree that's confusing. The buttons are to tell the server whether to interpret the program as PSOL or JSOL, so they are necessary. For example, write a program in JSOL and check the PSOL button, and you'll get an error.

I would like to clean up the interface though to make that more clear. Any suggestions?

LarryBattle commented 12 years ago

Replace the radio buttons with the selection and eval button side by side. Pass additional parameters with the POST that determine the compile mode.

clarkduvall commented 12 years ago

The POST is already passing additional parameters (thats what the PSOL/JSOL radio buttons are for). The problem is that if a user types in arbitrary code into the box, there is no way to tell if it is PSOL or JSOL. I could try to run it as PSOL, and if I get an exception fall back to JSOL, but thats pretty hacky and will return the wrong error messages in some cases.

LarryBattle commented 12 years ago

Isn't JSOL valid JSON, while PSOL isn't?

I think it would be better if you separated the two sources. Have JSOL on one side and PSOL on the other.

Anyhow it seems ok with the current version because I just now realized that the text box allows the user to parse custom JSOL/PSOL. I original thought it was only to display code.