search

clarkeash / doorman

Limit access to your Laravel applications by using invite codes
https://packagist.org/packages/clarkeash/doorman
MIT License
1.02k stars 45 forks source link

Add Cleanup Command #16

Closed m1guelpf closed 7 years ago

m1guelpf commented 7 years ago

Fix #10

codecov-io commented 7 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #16   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       48     51    +3     
=======================================
  Files             7      8    +1     
  Lines           125    134    +9     
=======================================
+ Hits            125    134    +9
Impacted Files Coverage Δ Complexity Δ
src/Providers/DoormanServiceProvider.php 100% <100%> (ø) 3 <0> (+1) :arrow_up:
src/Commands/CleanupCommand.php 100% <100%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b46fcbf...880bdef. Read the comment docs.

clarkeash commented 7 years ago

Are you able to add some tests?

m1guelpf commented 7 years ago

@clarkeash I will add them when I get to a computer

m1guelpf commented 7 years ago

@clarkeash Everything seems to be OK, but Travis is failing with a database error. Do you know what happened?

clarkeash commented 7 years ago

Yea use the DatabaseMigrations trait instead of DatabaseTransactions

m1guelpf commented 7 years ago

@clarkeash Done!

m1guelpf commented 7 years ago

@clarkeash Any updates on this?

clarkeash commented 7 years ago

I will merge this, I am away at the moment but will get to it soon.