search

clarkeash / doorman

Limit access to your Laravel applications by using invite codes
https://packagist.org/packages/clarkeash/doorman
MIT License
1.02k stars 45 forks source link

Customize Invite length #19

Closed m1guelpf closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #19 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity       48     48           
=======================================
  Files             7      7           
  Lines           125    125           
=======================================
  Hits            125    125
Impacted Files Coverage Δ Complexity Δ
src/Generator.php 100% <100%> (ø) 9 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b46fcbf...acb756e. Read the comment docs.

m1guelpf commented 7 years ago

@clarkeash Codecov says the coverage doesn't change... so does it need tests?

clarkeash commented 7 years ago

Hi @m1guelpf thanks for your work on this but I am not going to merge it as this will be handled differently. I am working on the code to support #17 which will allow configuration on a driver basis. see the config file - This branch is still in development so things may change.