Closed bweston92 closed 6 years ago
Merging #25 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 100% 100%
- Complexity 53 66 +13
=======================================
Files 9 11 +2
Lines 140 184 +44
=======================================
+ Hits 140 184 +44
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Doorman.php | 100% <100%> (ø) |
12 <0> (ø) |
:arrow_down: |
src/Models/Invite.php | 100% <100%> (ø) |
15 <1> (+2) |
:arrow_up: |
src/Exceptions/ExpiredInviteCode.php | 100% <100%> (ø) |
1 <1> (?) |
|
src/Providers/DoormanServiceProvider.php | 100% <0%> (ø) |
3% <0%> (ø) |
:arrow_down: |
src/DoormanManager.php | 100% <0%> (ø) |
7% <0%> (+4%) |
:arrow_up: |
src/Generator.php | 100% <0%> (ø) |
10% <0%> (ø) |
:arrow_down: |
src/Validation/DoormanValidator.php | 100% <0%> (ø) |
9% <0%> (ø) |
:arrow_down: |
src/Commands/CleanupCommand.php | 100% <0%> (ø) |
1% <0%> (ø) |
:arrow_down: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 349a1f3...b38896a. Read the comment docs.
closing for inactivity.
@bweston92 sorry about that, I read the PR then forgot to reply (as no longer had notifications) I am not against this PR. Other things have been taking up my time lately so doorman hasnt had much love. I am planning on tagging v2 or doorman some time next month (once I am back from vacation) so we could potentially look at this again then. 😄
Sorry @clarkeash - I understand I didn't want to rush you as I know this is just OSS, it was just a few months had past so I thought it had just gone stale.
If you're returning the message straight to the user might be helpful to know when it expired.