Closed mikemand closed 5 years ago
Adding support for 6 is not as simple as this. I am working on it now, thanks though 😄
Hi @clarkeash,
What else did I miss? As far as I know, you aren't overriding anything from the upgrade guide, and I did a search for the str_*
helpers and didn't find any used.
I'm just wondering what I missed so I don't make the same mistake again. Thanks!
Because of this if you did a composer install locally you would have gotten laravel 5.8 anyway.
I am almost finished.
Ah, I see. Thank you for explaining. 👍
@mikemand I have pushed to master, any chance you could give it a try before I tag v4?
Unfortunately, my one project that is "ready" for Laravel 6 still has several packages waiting for Laravel 6 support. I tried to remove the ones I was waiting on, but it was like fighting a hydra.
I will spin up a blank Laravel 6 project to test with.
It works for me. I can generate and redeem, and all the expected Exceptions get thrown if I try to redeem too many times or for the wrong user.
Great, Thanks for your help
You're welcome. 👍
v4 is tagged!
Don't mind me trying to sneak a docblock into the package... 😛