Add support for Laravel 6.0

clarkeash / doorman

Limit access to your Laravel applications by using invite codes

https://packagist.org/packages/clarkeash/doorman

MIT License

1.02k stars 45 forks source link

Add support for Laravel 6.0 #46

Closed mikemand closed 5 years ago

mikemand commented 5 years ago

Don't mind me trying to sneak a docblock into the package... 😛

clarkeash commented 5 years ago

Adding support for 6 is not as simple as this. I am working on it now, thanks though 😄

mikemand commented 5 years ago

Hi @clarkeash,

What else did I miss? As far as I know, you aren't overriding anything from the upgrade guide, and I did a search for the str_* helpers and didn't find any used.

I'm just wondering what I missed so I don't make the same mistake again. Thanks!

clarkeash commented 5 years ago

PHP minimum to 7.2 (because of laravel 6)
Orchestra Testbench needs upgrading to 4.0
PHPunit needs upgrading to 8.0 (because of testbench)
PHPunit deprecations from 8.0 to deal with
Carbon upgrade caused test failures.

Because of this if you did a composer install locally you would have gotten laravel 5.8 anyway.

I am almost finished.

mikemand commented 5 years ago

Ah, I see. Thank you for explaining. 👍

clarkeash commented 5 years ago

@mikemand I have pushed to master, any chance you could give it a try before I tag v4?

mikemand commented 5 years ago

Unfortunately, my one project that is "ready" for Laravel 6 still has several packages waiting for Laravel 6 support. I tried to remove the ones I was waiting on, but it was like fighting a hydra.

I will spin up a blank Laravel 6 project to test with.

mikemand commented 5 years ago

It works for me. I can generate and redeem, and all the expected Exceptions get thrown if I try to redeem too many times or for the wrong user.

clarkeash commented 5 years ago

Great, Thanks for your help

mikemand commented 5 years ago

You're welcome. 👍

clarkeash commented 5 years ago

v4 is tagged!