Closed m1guelpf closed 7 years ago
Hi, Thanks for your contribution.
The Invite model also needs to use this value, if you update the model I will look into merging this PR
@clarkeash Done!
Tests have failed. You cant use function calls to set default values for properties.
You will have to set the table name in in the models constructor 😄
@m1guelpf what happened?
@clarkeash I searched a bit and didn't find another way to set the table name of a model
You can just do it in the constructor:
public function __construct()
{
$this->table = config('doorman.invite_table_name');
}
@clarkeash That wouldn't work as the $table
value is overwritten later. I've reviewed the core and I think the setTable function may work.
overwritten by what?
and setTable is fine, but you still need to do this in the constructor, you cant just call a method like that in PHP
Codecov Report
100% <100%> (ø)
1 <1> (?)
100% <0%> (ø)
2% <0%> (ø)
100% <0%> (ø)
13% <0%> (+1%)
100% <0%> (ø)
9% <0%> (?)
Continue to review full report at Codecov.