Better lifecycle hooks - Githubissues

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels

Other

490 stars 110 forks source link

Better lifecycle hooks #109

Closed ktonon closed 5 years ago

ktonon commented 6 years ago

after hooks behave the same as before hooks, with chain of middleware
added key as the item when it would otherwise be null

The motivation is to be able to perform some kind of operation after a successful change to DynamoDB. For example, updating elasticsearch. This makes it possible to wait for that secondary operation to complete.

Passing in the key to the hook handlers (at minimum) makes it possible to identify the affected item at the very least.

ktonon commented 6 years ago

This is a client breaking change which would require a major version bump

coveralls commented 6 years ago

Coverage decreased (-0.01%) to 98.646% when pulling eb92f237d8c401495394f7cd260b7e38fc56aa71 on ktonon:better-lifecycle-hooks into 6b3f75c123ec1924d70d0ab1178519012c98b079 on clarkie:master.

jkav77 commented 6 years ago

@ktonon Better hooks sounds better in principle. Can you elaborate on this a bit?

What is the use case that this solves?
I take it there isn't an issue associated with this?
What would this break? That is, what changes would people need to make to adjust to this change?