search

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

Remove update validation #129

Closed jkav77 closed 2 years ago

jkav77 commented 6 years ago

This removes the attempt to partially validate the Joi schema on update requests. Joi does not provide the functionality to do this and attempting to write a partial schema validation function was problematic and not within the scope of dynogels. There was an issue asking about this in Joi (hapijs/joi#556) but they didn't want to implement this type of functionality either.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 4be09f6d8ce94d23e89f847ddd49104b67024a8b on dangerginger:remove-update-validation into on clarkie:master.

MaximusHaximus commented 6 years ago

Hey guys -- Is there a plan for which version this will land in? We're still using Dynogels 6.2 because of problems we encountered with upgrading to any version with fragment validation, but are keen to upgrade to the newest Dynogels version for other new functionality. Is this to be part of v10?

cdhowie commented 6 years ago

@MaximusHaximus It would definitely have to be a new major version since this change is not backwards-compatible.

MaximusHaximus commented 6 years ago

@cdhowie Thanks for the quick reponse! I figured it would be in a major release due to it's breaking nature and was just trying to get an idea of whether I should expect to see it in the next major release (v10) or if this is farther down the road :)

cdhowie commented 6 years ago

@MaximusHaximus I'd vote for it to be in v10. It's a broken feature and the sooner we get rid of it, the fewer people will depend on it.

MaximusHaximus commented 6 years ago

Yay :) I'd vote the same fwiw :)

rchl commented 5 years ago

Can new major be released with this change?