search

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

Adds support for server side encryption setting #136

Open armiiller opened 6 years ago

armiiller commented 6 years ago

Adds support for SSE on create table. See docs here: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/encryption.tutorial.html https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_CreateTable.html https://aws.amazon.com/about-aws/whats-new/2018/02/amazon-dynamodb-now-supports-server-side-encryption-at-rest/

armiiller commented 6 years ago

Hmm I seem to have broken something? Could this have been with the aws-upgrade? or possibly the tests don't know what to do with the new parameter? I am not familiar with the sinon package.

I did test this locally, and it worked for my project. Help to figure out why the tests are failing would be appreciated :)

armiiller commented 6 years ago

@clarkie

clarkie commented 6 years ago

Hi @armiiller, I wonder if it's the sdk upgrade?