Add SSESpecification when creating table with `encrypt` flag

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels

Other

490 stars 110 forks source link

Add SSESpecification when creating table with `encrypt` flag #143

Closed Floby closed 1 year ago

Floby commented 6 years ago

This PR adds the possibility to setup a encrypt flag to a schema :

If not specified, its value is false
if specified and true, then the correct configuration to enable table encryption is added to the creation request of the table
if false, then nothing is added to the creation request of the table

I know this is somewhat a duplicate of #136 but my branch seems to pass tests correctly (I guess we'll see how it goes)

Floby commented 6 years ago

Well, this PR passes all tests that the master branch passes ! :D

Floby commented 6 years ago

/wizz @clarkie

coveralls commented 6 years ago

Coverage increased (+0.004%) to 98.545% when pulling 2756981562aa641daae93ab0cba824574fe6b191 on Floby:feat-enable-table-encryption into df7acfeffe5ad22488bc2d40e9674c939df67ed8 on clarkie:master.

aneilbaboo commented 5 years ago

It would be nice to get this merged. Bump @clarkie.