Closed cdhowie closed 6 years ago
@clarkie @dangerginger If you guys are able to review this, I would like to get it done sooner rather than later; it touches nearly every source file and there is a high change it will conflict with any future merged PRs.
@clarkie @dangerginger Since there's been no review activity in 15+ days, I just pushed this. I don't want to hold this up.
Upgrades eslint and related packages to the latest versions available. This fixes three of the bitHound dependency tests (#148). I will be preparing another PR to deal with the remaining five tests, but since this is a fairly far-reaching set of changes, I wanted this one to be reviewed separately.
New warnings either in eslint or in eslint-config-airbnb-base were subsequently triggered and resolved as follows:
exports
andinternals
simultaneously using chained assignments (a = b = c;
). IMO, this is useful and makes the code clearer.a => { }
forms changed to(a) => { }
)new Buffer(...)
forms toBuffer.from(...)
.a - b * c
, grouping likea - (b * c)
makes the author's intent clear, even though that's what's happening anyway.)x++
forms tox += 1
.typeof(x)
forms totypeof x
.x.hasOwnProperty(y)
forms withObject.prototype.hasOwnProperty.call(x, y)
.x.__defineGetter__()
forms with equivalentObject.defineProperty()
calls.\
characters in string literals.