clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

Upgrade eslint; fix some new warnings and disable others #145

Closed cdhowie closed 6 years ago

cdhowie commented 6 years ago

Upgrades eslint and related packages to the latest versions available. This fixes three of the bitHound dependency tests (#148). I will be preparing another PR to deal with the remaining five tests, but since this is a fairly far-reaching set of changes, I wanted this one to be reviewed separately.

New warnings either in eslint or in eslint-config-airbnb-base were subsequently triggered and resolved as follows:

cdhowie commented 6 years ago

@clarkie @dangerginger If you guys are able to review this, I would like to get it done sooner rather than later; it touches nearly every source file and there is a high change it will conflict with any future merged PRs.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.08%) to 98.541% when pulling f1b343a9104e48ddd8b5abaa4db715e4569238ca on cdhowie:update-dependencies into a14b760b81c50407e7d1560b1503edd27a0eb374 on clarkie:master.

cdhowie commented 6 years ago

@clarkie @dangerginger Since there's been no review activity in 15+ days, I just pushed this. I don't want to hold this up.