search

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

Make aws-sdk a peer dependency #162

Open johnhaley81 opened 6 years ago

johnhaley81 commented 6 years ago

Much like joi, aws-sdk is often required by both the library and the consumer so it also makes sense to be a peer dependency as well.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 98.725% when pulling e203c0f1afe8757da6f3e273785f82295bb8aa98 on johnhaley81:make-aws-sdk-peer-dep into df7acfeffe5ad22488bc2d40e9674c939df67ed8 on clarkie:master.

ntanitime commented 6 years ago

Let's do it 👍

simlu commented 5 years ago

What's the hold up?

dremonkey commented 5 years ago

Why hasn't this been merged yet?

cdhowie commented 5 years ago

I can merge it but I'm not sure what good it would do; @clarkie doesn't seem to be around anymore and I don't have the ability to push releases to npm.

simlu commented 5 years ago

@cdhowie maybe it's time to fork and publish under a different package name?

simlu commented 5 years ago

Having said that... I'm in the process of writing my own orm. So I'm don't really care about this project much anymore (sorry).

dremonkey commented 5 years ago

@cdhowie @simlu Thanks for the updates. Good to know.

@simlu Be interested in seeing what you come up with. When's that coming out?