Update Dynogels to work with Joi v17

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels

Other

491 stars 110 forks source link

Update Dynogels to work with Joi v17 #196

Closed deedw closed 3 years ago

deedw commented 3 years ago

This pull request includes changes to dynogels to make it compatible with the latest version of Joi (v17.4.0 at time of writing). Tests and examples have also been updated.

This will be a breaking change for implementations that have schemas that are not compatible with Joi 17, for example Joi's any.default(value) no longer allows a description argument.

Joi's minimum node version is Node v8, so Dynogels' minimum version will also increase.

rchl commented 3 years ago

I'm not sure if someone is gonna merge your changes since this package is rather stale but you are not supposed to change the version in the PR. It's done on release.

deedw commented 3 years ago

Unexpected consequence of making another commit to my master branch after the original pull request. I hadn't realised additional commits would also be added to the pull request!

deedw commented 3 years ago

Updated pull request created from branch on my fork