upgrade to Joi v6 - Githubissues

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels

Other

490 stars 110 forks source link

upgrade to Joi v6 #4

Closed clarkie closed 8 years ago

clarkie commented 8 years ago

This bumps Joi from v5 to v6.

When using default(fn) in a schema a second argument needs to be passed:

PublishedDateTime: Joi.date().default(Date.now, 'now')

Error message formats have changed.

See here for the breaking changes inside Joi itself: https://github.com/hapijs/joi/issues/579

coveralls commented 8 years ago

Coverage decreased (-0.08%) to 98.573% when pulling 993e814b6d3c20387ff9b1436c0a384c030d7fbe on joi-upgrade into 438352da5eddbf3c4dbce8a0f193db7efbfe0473 on master.

coveralls commented 8 years ago

Coverage decreased (-0.002%) to 98.65% when pulling 1b1b46ad1f831f80a9a25e8fccee8c55368c38f6 on joi-upgrade into 438352da5eddbf3c4dbce8a0f193db7efbfe0473 on master.

clarkie commented 8 years ago

@sylwit and @justinffs as you both volunteered first, would it be possible for you to have a look over this? Thanks

justinffs commented 8 years ago

Looks ok to me, it there anything else in the docs that needs to be updated?

How much work would it be to upgrade Joi to the most recent version?

clarkie commented 8 years ago

@justinffs thanks for having a look. I don't think there's anything in the docs that needs to change at the minute but let me know if you spot anything.

My plan is to upgrade to the latest version of all of the dependencies but this does mean dropping support for node v0.10 and v0.12. I have already started in another branch and will push soon.

justinffs commented 8 years ago

Sounds good. I am assuming you will do a major version number bump when v0.10 and v0.12 are dropped?

clarkie commented 8 years ago

Already done ;)

dynogels v5.0.0 is out now!