clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

#42 Add `usingIndex` method to scan #45

Closed M1chaelTran closed 6 years ago

M1chaelTran commented 7 years ago

42

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 98.475% when pulling 2be528437e5874cabe85904dcb64cc4d022eb83d on SkribbleME:master into cd503bd5d975c68ccf14f63df39c64dd5802a578 on clarkie:master.

clarkie commented 7 years ago

Thanks @M1chaelTran. Any chance we could get a test for this? Thanks

M1chaelTran commented 7 years ago

sorry, i haven't had time or the knowledge at the moment to write test for this change.

if anyone else that need this function, please feel free to add test to it.

thank you in advance

jkav77 commented 6 years ago

Looks like this is now a duplicate with #45.

cdhowie commented 6 years ago

@dangerginger I think Github changed the way PRs associated with issues get handled. It effectively merged the two, so closing this issue also closed the PR. Should we reopen?