search

clarkie / dynogels

DynamoDB data mapper for node.js. Originally forked from https://github.com/ryanfitz/vogels
Other
490 stars 110 forks source link

Drop joi dependency in favor of json schema/ajv. PR accepted? #67

Closed cmawhorter closed 7 years ago

cmawhorter commented 7 years ago

As someone that is using dynogels heavily in lambda; Joi -- and anything hapijs -- is the bane of my existence.

Joi alone turns my lambda 850kb bundle.zip into 3mb. And because their community violently opposes bundlers, they've stated time and time again they DGAF about making it better.

(I also question the security when this stuff goes unfixed even after reporting. Everything in a few of hapijs projects is globally +x for some unknown reason.)

Is there any interest in a PR that drops Joi and replaces it with json schema and something like ajv?

JSON Schema is not without its quirks, but it's a standard that works everywhere. Also -- aws seems to be choosing it internally with their api gateway swagger support and other places.

iliasbhal commented 7 years ago

+1 !!!

nielsgl commented 7 years ago

@cmawhorter definitely would like to see that, have you implemented it in a fork?

clarkie commented 7 years ago

I haven't got the time to look at this but I'd be happy to have a look at a fork that does. Closing for now.