Could be great to have comment on the line

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details

https://clarkio.com

203 stars 14 forks source link

Could be great to have comment on the line #12

Closed yoannfleurydev closed 5 years ago

yoannfleurydev commented 5 years ago

I do not know if it is possible with VS Code, but it could be great to have the following:

User input in Twitch chat : !line 9 A comment
VS Code highlight the line 9 and on hover we can see the comment A comment.

danielpomas commented 5 years ago

Or show the comment with codelens above the line

twhitson commented 5 years ago

I think it would be great to have the ability to add comments to a line when highlighted. It could be rendered out similar to how the GitLens extension displays the most recent commit on that line.

See: https://github.com/eamodio/vscode-gitlens

clarkio commented 5 years ago

Thanks @yoannfleurydev for opening this issue and everyone that has provided input as well. We've now implemented this to show the comment on hover. We're open to looking into other ways of showing the comments such as the suggested codelens approach in the future.

It has now been added in #68. The plan is to publish this in version 0.1.5

clarkio commented 5 years ago

Also, as @parithon mentioned on stream today, it might not be best to show these comments in a codelens type view since that will automatically be visible and we may not want to show inappropriate comments. Having them "hidden" in the hover view helps prevent this we thinks 😄