clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details
https://clarkio.com
203 stars 14 forks source link

Determine Rate Limit Approach #51

Open clarkio opened 5 years ago

clarkio commented 5 years ago

I'm opening up this issue to provide a forum for discussion on how we can best implement a way to isolate and/or prevent abuse of the chat command.

So far some suggestions I've noticed from the community are as follows:

Please feel free to add more suggestions, expand on one or share which approach seems best to you.

DanielHe4rt commented 5 years ago

I think the first thing u need to do is check the command spam (i did't have time to read your code yet) and set some rules to timeout and ban. idk if this options can be setted by the user, but if not, there is a great idea

Apidcloud commented 5 years ago

You could also set a limit on the vs code client side (in addition to another one on twitch). That is, only X suggestions per minute (independent from the number of people suggesting)—sort of a funnel. After that threshold show a notification saying that there are Y on the queue (maybe listed per viewer) where you can choose to accept or not.

That said, I think it's really important to have safety checks on both sides. Say you have 50 viewers or more and each one highlights a line. I think it's way too much, and thus suggesting doing it at vs code side too.

ConnBB commented 5 years ago