search

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details
https://clarkio.com
203 stars 14 forks source link

Contrast of highlight might need some work #53

Closed corbob closed 5 years ago

corbob commented 5 years ago

Depending on the vscode theme in use, could actually make it harder to view contents.

Example: image

clarkio commented 5 years ago

Appreciate the feedback. Check out the VS Code settings Twitch Highlighter: Highlight Color and Twitch Highlighter: Highlight Border to customize the look that works best for your theme.

Let me know if that helps. If it does we can close this issue then.

corbob commented 5 years ago

It helps, but only for that comment. If I hit a line that's not comment it opens up more contrast issues. What about adding a foreground color along with it so you don't have to worry about syntax highlighting making it hard to read?

clarkio commented 5 years ago

This is a great suggestion and I've completed some work that adds a new setting to adjust the font color within highlights. It's currently open for review in #55. I'll close this issue once it has been reviewed, merged and published in the 0.1.4 release.

clarkio commented 5 years ago

55 has been merged now so we can close this and we'll publish a new release as version 0.1.4. Expect these changes in that updated version