search

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details
https://clarkio.com
203 stars 14 forks source link

Unhighlight all lines when disconnecting a session #64

Closed cmjchrisjones closed 5 years ago

cmjchrisjones commented 5 years ago

When disconnecting a session, any lines stay highlighted, it would be good to have an option as to whether when disconnecting we want to un-highlight all of the lines currently highlighted.

parithon commented 5 years ago

Great feature request! Do you think we need it as an option or should we assume that if you disconnect you want the highlights to go away too?

cmjchrisjones commented 5 years ago

@parithon - I thought it would be a good idea to let the 'host' decide if they want to disconnect and un-highlight all, or just disconnect, EG in case they're disconnecting for some unplanned reason, but don't necessarily want to un-highlight any lines at that point in case they want to come back to it later. This came up during a @RamblingGeekUK stream which @clarkio was part of at the time we were talking about it - I just took this slightly further by mentioning giving the host the option as to decide what they wanted when ending the session :)

clarkio commented 5 years ago

This is addressed in #67 and will be released in version 0.1.5. Please let us know your thoughts on approach and if it works for you. Thanks for sharing this feedback!