Set channel setting in settings screen instead of settings.json

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details

https://clarkio.com

203 stars 14 forks source link

Set channel setting in settings screen instead of settings.json #74

Closed SpyderHunter03 closed 5 years ago

SpyderHunter03 commented 5 years ago

I think we should be able to enter the channel name in the settings screen (Ctrl + ,) instead of having to come into the settings.json screen.

lampewebdev commented 5 years ago

For multichannel setups:

Requirement

As a user of the extension, I want to set up multiple channels.

Possible implementation

Make it an array. Keep in mind that the 'string' now has to become array ['string'].
Make it a comma separate list 'string, string`

parithon commented 5 years ago

@lampewebdev Are you using multiple channels from the same service, that is multiple channels on Twitch?

SpyderHunter03 commented 5 years ago

@lampewebdev Where did that requirement come from? And have you seen a valid use case IN ACTION that would use multichannel setup? (I can come up with a valid use case but have not seen it being utilized)

_{Sent with GitHawk}

parithon commented 5 years ago

I have published a PR that changes the channels setting from an array of string to a comma separated string value. This will allow you to edit the channels from the settings screen (CTRL+,)!

clarkio commented 5 years ago

Addressed in #76 and expected to be released in 0.1.5. Thanks for this feedback @SpyderHunter03 and let us know if you have any further feedback on our approach to solving this issue.