search

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details
https://clarkio.com
203 stars 14 forks source link

highlights dont increase in size, they only decrease #87

Closed NickLarsen closed 3 years ago

NickLarsen commented 5 years ago 
!line 10

Then on line 10, add some space inside the highlight, and the highlight does not increase in size, it seems like it should always highlight the entire line even as it is edited. To contrast this, the highlight does get smaller as you delete text from the line, and if you add text back in after deleting some, it will continue to increase back to the size it was when the highlight was created.

parithon commented 5 years ago

I believe this is a bug with vscode. Once we place the highlight decorator on the editor it is vscode that is handling the decorators decrease in size.

For us to handle the increase, we would need to 'watch' all changes on the editor and cross-reference those changes with all the highlights attached to the editor and increase the highlights size if it doesn't match the previous size after the change. I wonder what that'll do to performance.

clarkio commented 3 years ago

This is fixed in #125 right @parithon ?

parithon commented 3 years ago

That is accurate. It should both increase and decrease in size now.

From: Brian Clark notifications@github.com Sent: Friday, August 21, 2020 5:26:12 PM To: clarkio/vscode-twitch-highlighter vscode-twitch-highlighter@noreply.github.com Cc: Anthony Conrad (parithon) parithon@outlook.com; Mention mention@noreply.github.com Subject: Re: [clarkio/vscode-twitch-highlighter] highlights dont increase in size, they only decrease (#87)

This is fixed in #125https://github.com/clarkio/vscode-twitch-highlighter/pull/125 right @parithonhttps://github.com/parithon ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/clarkio/vscode-twitch-highlighter/issues/87#issuecomment-678565823, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACBUGMUNX2BOFTJQANYEL3LSB4GCJANCNFSM4G5WQJPQ.

clarkio commented 3 years ago

Closing as this has been fixed. Thanks again for the feedback 🙂👍