search

clarkio / vscode-twitch-highlighter

This is a VS Code extension that will allow your Twitch chat to highlight a line of code via a command message. Example: `!line 8 server.js`. See master branch README.md for more details
https://clarkio.com
203 stars 14 forks source link

Remove Highlights from Users Banned in Chat #99

Closed clarkio closed 5 years ago

clarkio commented 5 years ago

Finished implementation that was started with mpj on https://twitch.tv/funfunfunction.

Big thanks to @parithon for helping simplify the code for removing highlights based on banned username with function overloads 👍 👉 https://gist.github.com/parithon/7b165c22e797186e7649378aa3a01351

Partially addresses #51

parithon commented 5 years ago

The tests are failing because it expects the constants.Commands to be listed among the contribution commands configuration in the package.json file. However, the only commands that should exist in the package.json are those commands that are registered with vscode and executed by the user via the UI.

We need to refactor the constants.Commands, as well as the package.json, to separate commands between registered commands (those commands registered with vscode, such as startChat) and internal commands (those commands that aren't registered with vscode, such as removeBannedHighlights).

clarkio commented 5 years ago

I should get to fixing this up tonight. I'll refactor and look to add tests for the internal commands too.

clarkio commented 5 years ago

bitmoji