Faster bytes parsing - Githubissues

clarkmcc / cel-rust

Common Expression Language interpreter written in Rust

https://crates.io/crates/cel-interpreter

MIT License

362 stars 18 forks source link

Faster bytes parsing #69

Closed alexsnaps closed 2 months ago

alexsnaps commented 2 months ago

Couldn't help it ;)

Thanks to your feedback here, I decided to:

[x] Added a bench for parsing bytes
[x] Changed the implementation to use a temp buffer

Also a -21~24% improvements on escaped sequences. Overall better... For us the parsing is less important (and not even x86/arm assembly anyways). But no one ever complained about things being faster. This indeed saves the vector allocation due to the String conversion.

clarkmcc commented 2 months ago

Ha! Love it, nothing like a little benchmarking on a Saturday. Lgtm