search

clarkwinkelmann / flarum-ext-emojionearea

Add EmojioneArea emoji picker to Flarum
https://discuss.flarum.org/d/4787
MIT License
27 stars 12 forks source link

EmojiOne Area pulls libraries from cdnjs.cloudflare.com #1

Open clarkwinkelmann opened 7 years ago

clarkwinkelmann commented 7 years ago

This is probably due to the default configuration of the library.

It fetches images at cdnjs.cloudflare.com whereas the base emoji plugin fetches them at cdn.jsdelivr.net.

It also load additional css and js files from cdnjs.cloudflare.com. These files are probably already included in the core and should not be fetched again.

clarkwinkelmann commented 7 years ago

emojione.min.js is still fetched from cdnjs. It seems this file is not loaded by Flarum core or emoji picker so that's the reason it is loaded.

Emojione Area does not seem to have a way to change the CDN for that action :angry:

https://github.com/mervick/emojionearea/blob/master/src/function/loadEmojione.js#L45

pribbernow-marc commented 7 years ago

yes, would be great to deactivate that part if the option "useInternalCDN" is deactivated