search

clarkwinkelmann / flarum-pages-generator

Generate pseudo-static pages from markdown and HTML files for Flarum
https://discuss.flarum.org/d/28770
MIT License
8 stars 0 forks source link

FoF Sitemap doesn't detect generated pages #1

Open iamdarkle opened 3 years ago

iamdarkle commented 3 years ago

When checking that Google Search Console had correctly removed the old fof/pages links I noticed that the new ones from flarum-pages-generator were not appearing and I confirmed this by looking at the sitemap.xml, it seems that fof/sitemap is not able to detect the pages generated through flarum-pages-generator.

clarkwinkelmann commented 3 years ago

That's expected. FoF Sitemap cannot "detect" any page, it needs a custom adapter for each kind of page source.

Right now there's no adapter to feed static pages to Sitemap. I can try adding this in a future release.

Either this extension or Sitemap could add the additional logic. But it wouldn't make sense to add the logic on the Sitemap side until this package is deemed stable so adding it on this side is probably best.

iamdarkle commented 3 years ago

Ok now I understand it better, I didn't know FoF Sitemap worked like that, it makes sense, sorry for the misunderstanding 😅, do you prefer to close the issue then?

clarkwinkelmann commented 3 years ago

We can keep the issue open. This is a feature that would make a lot of sense.

I'm thinking this could be a secondary extender bundled with this package. That way it can be enabled only if the owner wants it.