claroline / Claroline

Learning management system
https://www.claroline.com
Other
320 stars 189 forks source link

[Registration] Cannot close confirmation modal on DEV builds #1964

Open YanaMIvanova opened 2 years ago

YanaMIvanova commented 2 years ago
Q A
Bug report? yes
Version? 13.0, 13.1, 13.5

Steps:

  1. Install Claroline from branch 13.0 or 13.1
  2. Enable self-registration
  3. Open the registration form and proceed to the last page
  4. Click on "Create an account" button in order to trigger the Registration modal
  5. Try to close it using the X button

Expected: The modal should close

Actual: The modal stays open and errors are thrown

image

maieutiquer commented 2 years ago

This issue is totally blocking manual account creation, as well as #1963, so it's inherently urgent for us

maieutiquer commented 2 years ago

We found that this is caused by the redux-freeze library, not sure why it started happening now and not earlier given that there are no recent versions, but closing the modal and creating new accounts works after commenting out the following lines:

https://github.com/claroline/Claroline/blob/9fd9122550ca14e54e78868366dc4ad6addfff5c/src/main/app/Resources/modules/store/index.js#L25

image

This also explains why we observe this issue for DEV builds only