search

clartaq / cwiki

A personal wiki written in Clojure/Script
Other
3 stars 0 forks source link

Status Animations on Backup and Restore Not Always Working #25

Closed clartaq closed 4 years ago

clartaq commented 4 years ago

Under some conditions, the status messages when doing backup or restore don't always work.

clartaq commented 4 years ago

Just spit ballin' here, but it seems to work ok after launching the program from the dev repl, but not from the uberjar.

They each load a different version of the CSS. The uberjar uses a minified version while the repl uses the full-sized version. Something to check.

clartaq commented 4 years ago

Since the buttons on the page fail to enable/disable correctly, it's probably an issue in the event handlers for the buttons.

clartaq commented 4 years ago

It seems these problems have multiple causes.

  1. The handling of the submit button for the forms that trigger these processes were not best practices. Moving to handling the forms submit action with on submit handlers for each form.
  2. The new handlers prevent multiple submits of a form and offer a better UI in my opinion.
  3. The asset minimizer plugin used in the build has a bug that affects the program when compiled to an uberjar. Minimizing the CSS has been removed from the program and build process, at least temporarily.
  4. With these mitigations, the program works as expected for backup/restore and import/export, the 4 potentially long-running processes that use a status animation.
  5. Even with the above mitigations, these handlers still perform unreliably on Safari. The processes themselves work as expected, but the UI does not always work as desired on Safari.