clash-lang / clash-compiler

Haskell to VHDL/Verilog/SystemVerilog compiler
https://clash-lang.org/
Other
1.44k stars 153 forks source link

Disable two problematic Vivado tests in test suite #2515

Closed DigitalBrains1 closed 1 year ago

DigitalBrains1 commented 1 year ago

Due to bugs in Vivado

I split off VHDL so I could disable those specifically. This makes the code less pleasant to look at, but I do like that at least the Verilog test is still run for as much coverage as we can hope for. It does change the visual layout when running the test. Before:

  tests
    shouldwork
      Signal
        DynamicClocks
          VHDL
            clash (gen):                  OK (7.18s)
            GHDL
              ghdl (import testBench):    OK (0.03s)
              ghdl (make testBench):      OK (2.17s)
              ghdl (sim testBench):       OK (0.09s)
            Vivado
              vivado (sim testBench): [...]
          Verilog
            clash (gen):                  OK (6.53s)
            IVerilog
              iverilog (make testBench):  OK (0.08s)
              iverilog (sim testBench):   OK (0.04s)
            Vivado
              vivado (sim testBench):     OK (25.17s)
          SystemVerilog
            clash (gen):                  OK (7.02s)
            ModelSim
              modelsim (vlib testBench):  OK (0.03s)
              modelsim (vlog testBench):  OK (0.09s)
              modelsim (sim testBench):   OK (0.84s)

After:

  tests
    shouldwork
      Signal
        DynamicClocks
          VHDL
            clash (gen):                  OK (5.24s)
            GHDL
              ghdl (import testBench):    OK (0.02s)
              ghdl (make testBench):      OK (1.51s)
              ghdl (sim testBench):       OK (0.08s)
        DynamicClocks
          Verilog
            clash (gen):                  OK (5.72s)
            IVerilog
              iverilog (make testBench):  OK (0.07s)
              iverilog (sim testBench):   OK (0.02s)
            Vivado
              vivado (sim testBench):     OK (18.73s)
          SystemVerilog
            clash (gen):                  OK (5.44s)
            ModelSim
              modelsim (vlib testBench):  OK (0.03s)
              modelsim (vlog testBench):  OK (0.07s)
              modelsim (sim testBench):   OK (0.56s)

Still TODO: