Closed martijnbastiaan closed 1 year ago
Maybe add
-- See [Note: eta port names for trueDualPortBlockRam]
{-# OPTIONS_GHC -fno-do-lambda-eta-expansion #-}
?
@christiaanb was pretty much against that last time around, but I don't remember the reasoning.
For this specific primitive: only clk
will result in an HDL port name. The rest are blackbox-only arguments.
@christiaanb was pretty much against that last time around, but I don't remember the reasoning.
It was because in that case there was no need for the separate module. So you created a separate module specifically to get nice names. Here we do want a separate module for another reason. So we generate nice names for our separate module instead of a separate module for nice names. They're basically each other's reverse.
Ok! Done!
Thanks! Will set it to draft to make sure it doesn't get merged before https://github.com/clash-lang/clash-compiler/pull/2511.
Fixes #2500
Still TODO:
Write a changelog entry (see changelog/README.md)