clash-prelude: Add ShowX (Proxy a) instance

clash-lang / clash-compiler

Haskell to VHDL/Verilog/SystemVerilog compiler

https://clash-lang.org/

Other

1.4k stars 147 forks source link

clash-prelude: Add ShowX (Proxy a) instance #2637

Closed bgamari closed 5 months ago

bgamari commented 6 months ago

Both I and clash-protocols have found this instance useful, leading to overlapping instances. Let's put it where it belongs.

Still TODO:

[x] Write a changelog entry (see changelog/README.md)
[ ] Check copyright notices are up to date in edited files

bgamari commented 6 months ago

One question is how this should be versioned until the next release is made. I would suggest that the version of clash-prelude be bumped such that downstream users can rely on CPP to guard existing orphans.

martijnbastiaan commented 5 months ago

One question is how this should be versioned until the next release is made. I would suggest that the version of clash-prelude be bumped such that downstream users can rely on CPP to guard existing orphans.

The next release (for 1.8) will be 1.8.2, which should be guardable using MIN_VERSION_clash_prelude.

martijnbastiaan commented 5 months ago

@kloonbot run_ci dbed0535843345a9634196d33b6d4f88283b04ad

I only now realize what you were saying: you want to bump the version on master to reflect the API changes. We haven't done this before, and IMO this is a bit too much overhead for development. If you want a more principled discussion I'd suggest opening a Discussions thread. For now this LGTM, and I'll merge it!