On the release of `clash-cores`

clash-lang / clash-compiler

Haskell to VHDL/Verilog/SystemVerilog compiler

https://clash-lang.org/

Other

1.45k stars 154 forks source link

On the release of `clash-cores` #2757

Open martijnbastiaan opened 4 months ago

martijnbastiaan commented 4 months ago

Tasks:

[x] Move clash-cores/ to clash-lang/clash-cores
- [x] Create repo
- [ ] Remove code from clash-lang/clash-compiler: note that clash-testsuite also refers to clash-cores
[ ] Setup CI on clash-lang/clash-cores
[ ] Decide which cores are experimental / likely to change and mark them as internal/experimental
Resolve issues with building under Clash 1.8: (resolve could mean: fix bugs, release Clash 1.10 and use that, disable problematic cores for 1.8 specifically)
- [ ] https://github.com/clash-lang/clash-compiler/issues/2806
- [ ] https://github.com/clash-lang/clash-compiler/issues/2807
- [ ] https://github.com/clash-lang/clash-cores/issues/9
- [ ] Decide on licence for clash-cores

DigitalBrains1 commented 4 months ago

I think it would be good if we could merge the fourmolu formatting PR on clash-compiler before we split the repo's, so there is no need for another .git-blame-ignore-revs file in the new repo. But it's not a really big issue, just a nice-to-have.

DigitalBrains1 commented 3 months ago

Do we want to split off the full history of everything happening in clash-compiler/clash-cores into the new repository, using git subtree?

Or do we want a new initial commit on the new repo with all the code as it currently is, and direct people to clash-compiler for the history before that?

@t-wallet and I both prefer the first.

jvnknvlgl commented 3 months ago

I have added a clash-cores label to mark everything that needs to be moved to the new repository when the time is there.

leonschoorl commented 3 months ago

There are still many references to clash-cores in the CI infra:

https://github.com/clash-lang/clash-compiler/blob/5927123c1df848190e87cd0830b6a533139ebb39/.github/workflows/ci.yml#L221-L222

https://github.com/clash-lang/clash-compiler/blob/5927123c1df848190e87cd0830b6a533139ebb39/.ci/gitlab/test.yml#L94-L97

https://github.com/clash-lang/clash-compiler/blob/5927123c1df848190e87cd0830b6a533139ebb39/.ci/gitlab/test.yml#L99-L102

https://github.com/clash-lang/clash-compiler/blob/5927123c1df848190e87cd0830b6a533139ebb39/.ci/gitlab/test.yml#L160-L169

That last one is now completely pointless after #2793 got merged.