search

clash-lang / clash-protocols

a battery-included library for dataflow protocols
Other
19 stars 7 forks source link

Move plugin to a separate package #104

Closed t-wallet closed 3 months ago

t-wallet commented 3 months ago

Fixes #103

martijnbastiaan commented 3 months ago

Could you move clash-protocols to a similarly named folder? Like clash-compiler does for its packages. Other than that LGTM.

t-wallet commented 3 months ago

Could you move clash-protocols to a similarly named folder? Like clash-compiler does for its packages. Other than that LGTM.

Done!

bgamari commented 3 months ago

It doesn't seem right that this change is user-visible; requiring the user to add two entries to build-depends just to use this package seems needlessly burdensome.

Why not reexport the plugin from clash-protocols (e.g. using Cabal's reexported-modules feature)?

martijnbastiaan commented 3 months ago

Agreed, @t-wallet could you re-export?

bgamari commented 3 months ago

Done in #106