search

clasp-developers / clasp

clasp Common Lisp environment
https://clasp-developers.github.io/
2.54k stars 142 forks source link

Clasp release archive 2.6.0 is still checking for git program #1590

Open Uthar opened 4 weeks ago

Uthar commented 4 weeks ago

Describe the bug Building from 2.6.0 release archive still checks for git.

Expected behavior With the new release, dependencies which were previously downloaded from git are now bundled. With that the build should work on a system with no git installed.

Actual behavior Running the koga initialisation script from an unpacked Clasp 2.6.0 archive stops with an error message when there is no git program installed on the system.

Steps to reproduce

  1. wget https://github.com/clasp-developers/clasp/releases/download/2.6.0/clasp-2.6.0.tar.gz
  2. tar xf clasp-2.6.0.tar.gz && cd clasp-2.6.0
  3. PATH='' $(which sbcl) --script ./koga --skip-sync
...
Found https://github.com/seqan/seqan.git clone in extensions/seqan-clasp/seqan/, assuming everything is okay.

Configuring the build
Configuring git
Unable to find git program.
yitzchak commented 4 weeks ago

I haven't decided whether to remove this check yet. git is still used in some places.