clasp-developers / clasp

clasp Common Lisp environment
https://clasp-developers.github.io/
2.58k stars 145 forks source link

Broken submodules on testing branch #259

Closed dunn closed 8 years ago

dunn commented 8 years ago

Some of the submodule definitions are missing from the testing branch:

diff --git a/.gitmodules b/.gitmodules
index 875692c..fb9eae1 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,18 +1,9 @@
 [submodule "src/lisp/kernel/contrib/sicl"]
        path = src/lisp/kernel/contrib/sicl
-       url = https://github.com/robert-strandh/SICL.git
-[submodule "src/mps"]
-       path = src/mps
-       url = https://github.com/clasp-developers/mps-temporary.git
+       url = https://github.com/clasp-developers/SICL.git
 [submodule "src/lisp/modules/asdf"]
        path = src/lisp/modules/asdf
        url = https://github.com/drmeister/asdf.git
-[submodule "src/boehm/libatomic_ops"]
-       path = src/boehm/libatomic_ops
-       url = https://github.com/ivmai/libatomic_ops
-[submodule "src/boehm/bdwgc"]
-       path = src/boehm/bdwgc
-       url = https://github.com/ivmai/bdwgc
-[submodule "tools/boost_build"]
-       path = tools/boost_build
-       url = https://github.com/clasp-developers/build
+[submodule "src/mps"]
+       path = src/mps
+       url = https://github.com/Ravenbrook/mps.git

This means that a recursive clone/checking out submodules fails:

🌲  git submodule init
fatal: No url found for submodule path 'tools/boost_build' in .gitmodules

Was this intentional? If so, what's the correct way to build the testing branch?

Thanks!

Shinmera commented 8 years ago

Yes, those are no longer required. Building requires merely cloning the repository directly, setting up the local.config file to point to the externals-clasp directory after having built that, and then running make.

dunn commented 8 years ago

Are none of the submodule used? Should they be removed, along with .gitmodules? I can open a PR for that.

drmeister commented 8 years ago

A few submodules are used (sicl, mps) but I've eliminated boehm and atomic_ops in the past couple of months.

Shinmera commented 8 years ago

Should be done now I think? Reopen if I've missed something.