[BattleGrounds] Turn in quests functionality - Githubissues

classicdb / database

Classic DB is a content database for CMaNGOS Classic: world, NPCs, objects, quests and so on.

https://github.com/cmangos/mangos-classic

Other

87 stars 59 forks source link

[BattleGrounds] Turn in quests functionality #221

Open ghost opened 10 years ago

ghost commented 10 years ago

Can see all of the quests, believe it was level related which one you see.
"rewards You will earn: Honour Points +xxx" Using the debug image instead of honour image. Does not seem to actually award any honour regardless of which 3 tokens you turn in.

Phatcat commented 5 years ago

@cala @Tobschinski - so I've gone in 2 different directions with this, both solving the issue, one utilizing db, one only utilizing core. I would love your input on which one you prefer before I open a PR

DB use; https://github.com/Phatcat/mangos-classic/commit/e62c6cdb92827ce02dcd77ca69e658ed0e81c389 (I prefer this one)

Core only; https://github.com/Phatcat/mangos-classic/commit/1ed7fabcd7543cbd6d7d6a5aef08f09be3f087e2 (messy but avoid editing template)

@Grz3s @AnonXS @killerwife @Warlockbugs

Any of you have any opinion on these solutions?

Tobschinski commented 5 years ago

Is RequiredCondition not enough for this?

killerwife commented 5 years ago

I do vaguely understand it from the source code, but I would love to have explained why the issue exists in the first place. Blizzard had several quests for different brackets?

Tobschinski commented 5 years ago

Nvm, I'm fine with the MaxField as well. untitled

killerwife commented 5 years ago

If it is needed, go for it. @Phatcat amend your DB field addition so that DEFAULT is always 255, and you can then always simply check in core without having to do "maxlevel&&". Edit: and make a PR